-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs sphinx 4 upgrade #2666
Docs sphinx 4 upgrade #2666
Conversation
The highlighttable CSS class is no more used by any element on the pygame docs.
…yed inline on mobile devices
15px for wide screen, 10px for mobile devices
Ok, thanks for your review. About the first and the last points, it's my fault, I fixed some responsive issues but ended to the generation of the desktop issues you are showing, I know how to fix them. About the second point, I'm sorry I can't reproduce the issue, the rendering is like this on my side: Sphinx version: 4.1.2 (last) I think it's mostly Pygments' work to determine syntax highlighting for codeblocks, so maybe you have a different version of it. |
…page and removed some horizontal margin between block title and content
Alright, I've taken another look at this To get this working properly, I needed: So, with the docutils 0.16 caveat, I think I'm ready to approve this. This limit would need to be documented though. You could continue in another PR? - |
Great. But I'm wondering ; maybe I could get around the docutils issue in this PR? This should be quick (one css rule probably), it is somewhat related to the Sphinx 4 upgrade and I think it would be "too much" to add a notice about this issue in the documentation only to remove it in a few months. |
That would be wonderful. |
The title are under a section tag instead of a div with a "section" class starting from docutils v0.17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for working on this @Grimmys! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks. Very nice to be up to date with sphinx again.
According to #2598, this PR modify the CSS rules for the docs to be compatible with Sphinx last version (4.1.2)
The issue related to the rendering of an image next to a codeblock has been fixed.
The rendering of a codeblock has been improved to be similar to what it is actually online.
I tried to pay attention to responsive design, Sphinx upgrade let the global appearance much more correct on mobile devices: all the elements are bigger to be more visible, and I added rules to prevent elements from going out of the main container when they are too big.